trushev commented on code in PR #5830:
URL: https://github.com/apache/hudi/pull/5830#discussion_r1033190639


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -120,6 +121,12 @@ private FlinkOptions() {
       .withDescription("The default partition name in case the dynamic 
partition"
           + " column value is null/empty string");
 
+  public static final ConfigOption<Boolean> SCHEMA_EVOLUTION_ENABLED = 
ConfigOptions
+      .key(HoodieCommonConfig.SCHEMA_EVOLUTION_ENABLE.key())
+      .booleanType()

Review Comment:
   Replaced with deprecated 
`conf.getBoolean(HoodieCommonConfig.SCHEMA_EVOLUTION_ENABLE.key(), false)`



##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -120,6 +121,12 @@ private FlinkOptions() {
       .withDescription("The default partition name in case the dynamic 
partition"
           + " column value is null/empty string");
 
+  public static final ConfigOption<Boolean> SCHEMA_EVOLUTION_ENABLED = 
ConfigOptions
+      .key(HoodieCommonConfig.SCHEMA_EVOLUTION_ENABLE.key())
+      .booleanType()

Review Comment:
   If there is no this ConfigOption we need to get the value from flink conf 
using deprecated 
   `conf.getBoolean(HoodieCommonConfig.SCHEMA_EVOLUTION_ENABLE.key(), false)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to