yihua commented on code in PR #7224: URL: https://github.com/apache/hudi/pull/7224#discussion_r1034257182
########## packaging/hudi-cli-bundle/pom.xml: ########## @@ -0,0 +1,275 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi</artifactId> + <groupId>org.apache.hudi</groupId> + <version>0.13.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hudi-cli-bundle_${scala.binary.version}</artifactId> + <packaging>jar</packaging> + + <properties> + <checkstyle.skip>true</checkstyle.skip> + <main.basedir>${project.parent.basedir}</main.basedir> + <skipTests>true</skipTests> + <javax.servlet.version>3.1.0</javax.servlet.version> + </properties> + + <build> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>${maven-shade-plugin.version}</version> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <createSourcesJar>${shadeSources}</createSourcesJar> + <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml + </dependencyReducedPomLocation> + <transformers> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer" /> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer"> + <addHeader>true</addHeader> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer"> + <resource>META-INF/LICENSE</resource> + <file>target/classes/META-INF/LICENSE</file> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.handlers</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.schemas</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.factories</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/> + <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> + <mainClass>org.apache.hudi.cli.Main</mainClass> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.actuate.autoconfigure.web.ManagementContextConfiguration.imports</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports</resource> + </transformer> + </transformers> + <artifactSet> + <includes combine.children="append"> + <include>org.apache.hudi:hudi-cli</include> + <include>org.apache.hudi:hudi-utilities_${scala.binary.version}</include> + + <!-- cli related dependencies --> + <include>org.springframework*:*</include> + <include>org.springframework.boot:*</include> + <include>org.apache.logging.log4j:*</include> + <include>org.scala-lang:scala-library</include> + <include>org.apache.parquet:parquet-hadoop</include> + <include>com.google.guava:guava</include> Review Comment: `com.google.guava` should be avoided or at least shaded. ########## packaging/hudi-cli-bundle/pom.xml: ########## @@ -0,0 +1,275 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi</artifactId> + <groupId>org.apache.hudi</groupId> + <version>0.13.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hudi-cli-bundle_${scala.binary.version}</artifactId> + <packaging>jar</packaging> + + <properties> + <checkstyle.skip>true</checkstyle.skip> + <main.basedir>${project.parent.basedir}</main.basedir> + <skipTests>true</skipTests> + <javax.servlet.version>3.1.0</javax.servlet.version> + </properties> + + <build> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>${maven-shade-plugin.version}</version> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <createSourcesJar>${shadeSources}</createSourcesJar> + <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml + </dependencyReducedPomLocation> + <transformers> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer" /> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer"> + <addHeader>true</addHeader> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer"> + <resource>META-INF/LICENSE</resource> + <file>target/classes/META-INF/LICENSE</file> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.handlers</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.schemas</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.factories</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/> + <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> + <mainClass>org.apache.hudi.cli.Main</mainClass> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.actuate.autoconfigure.web.ManagementContextConfiguration.imports</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports</resource> + </transformer> + </transformers> + <artifactSet> + <includes combine.children="append"> + <include>org.apache.hudi:hudi-cli</include> + <include>org.apache.hudi:hudi-utilities_${scala.binary.version}</include> + + <!-- cli related dependencies --> + <include>org.springframework*:*</include> + <include>org.springframework.boot:*</include> + <include>org.apache.logging.log4j:*</include> + <include>org.scala-lang:scala-library</include> + <include>org.apache.parquet:parquet-hadoop</include> + <include>com.google.guava:guava</include> + <include>org.apache.httpcomponents:httpclient</include> + <include>org.apache.httpcomponents:httpcore</include> + <include>org.apache.httpcomponents:fluent-hc</include> + <include>org.jline:*</include> + <include>org.yaml:*</include> + <include>commons-logging:*</include> + <include>org.apache.avro:avro</include> + <include>org.hibernate.validator:hibernate-validator</include> + <include>javax.validation:validation-api</include> + <include>jakarta.validation:jakarta.validation-api</include> + <include>org.jboss.logging:jboss-logging</include> + <include>com.fasterxml:classmate</include> + <include>org.glassfish:jakarta.el</include> + <include>com.fasterxml.woodstox:woodstox-core</include> + <include>org.codehaus.woodstox:stax2-api</include> + <include>commons-collections:commons-collections</include> + <include>commons-configuration:*</include> + <include>commons-lang:*</include> + <include>com.google.code.gson:gson</include> + <include>org.fusesource.jansi:jansi</include> + <include>net.java.dev.jna:jna</include> + <include>com.jakewharton.fliptables:fliptables</include> + <include>com.google.re2j:re2j</include> + <include>org.openjdk.jol:jol-core</include> + </includes> + </artifactSet> + <filters> + <filter> + <artifact>*:*</artifact> + <excludes> + <exclude>META-INF/*.SF</exclude> + <exclude>META-INF/*.DSA</exclude> + <exclude>META-INF/*.RSA</exclude> + <exclude>**/*.proto</exclude> + <exclude>**/Log4j2Plugins.dat</exclude> + </excludes> + </filter> + </filters> + <finalName>${project.artifactId}-${project.version}</finalName> Review Comment: What is this used for? Could you remove this line if it's not necessary? ########## hudi-cli/src/main/resources/log4j2.properties: ########## @@ -25,7 +25,7 @@ appender.console.layout.type = PatternLayout appender.console.layout.pattern = %-4r [%t] %-5p %c %x - %m%n # Root logger level -rootLogger.level = warn +rootLogger.level = info Review Comment: Have you committed the changes for the two comments? ########## packaging/hudi-cli-bundle/hudi-cli-bundle.sh: ########## @@ -0,0 +1,30 @@ +#!/usr/bin/env bash Review Comment: same here ########## packaging/hudi-cli-bundle/pom.xml: ########## @@ -0,0 +1,275 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi</artifactId> + <groupId>org.apache.hudi</groupId> + <version>0.13.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hudi-cli-bundle_${scala.binary.version}</artifactId> + <packaging>jar</packaging> + + <properties> + <checkstyle.skip>true</checkstyle.skip> + <main.basedir>${project.parent.basedir}</main.basedir> + <skipTests>true</skipTests> + <javax.servlet.version>3.1.0</javax.servlet.version> + </properties> + + <build> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>${maven-shade-plugin.version}</version> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <createSourcesJar>${shadeSources}</createSourcesJar> + <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml + </dependencyReducedPomLocation> + <transformers> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer" /> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer"> + <addHeader>true</addHeader> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer"> + <resource>META-INF/LICENSE</resource> + <file>target/classes/META-INF/LICENSE</file> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.handlers</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.schemas</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.factories</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/> + <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> + <mainClass>org.apache.hudi.cli.Main</mainClass> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.actuate.autoconfigure.web.ManagementContextConfiguration.imports</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports</resource> + </transformer> + </transformers> + <artifactSet> + <includes combine.children="append"> + <include>org.apache.hudi:hudi-cli</include> + <include>org.apache.hudi:hudi-utilities_${scala.binary.version}</include> + + <!-- cli related dependencies --> + <include>org.springframework*:*</include> + <include>org.springframework.boot:*</include> + <include>org.apache.logging.log4j:*</include> + <include>org.scala-lang:scala-library</include> + <include>org.apache.parquet:parquet-hadoop</include> + <include>com.google.guava:guava</include> Review Comment: Could you check hudi-presto-bundle or hudi-trino-bundle for relevant relocation rules? The hudi-cli-bundle might need those rules as well. ########## packaging/hudi-cli-bundle/pom.xml: ########## @@ -0,0 +1,275 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi</artifactId> + <groupId>org.apache.hudi</groupId> + <version>0.13.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hudi-cli-bundle_${scala.binary.version}</artifactId> + <packaging>jar</packaging> + + <properties> + <checkstyle.skip>true</checkstyle.skip> + <main.basedir>${project.parent.basedir}</main.basedir> + <skipTests>true</skipTests> + <javax.servlet.version>3.1.0</javax.servlet.version> Review Comment: Do we have to specify the version here? I see hudi-spark-bundle has this but other bunldes like hudi-presto-bundle and hudi-utilities-bundle do not specify the version. ########## packaging/hudi-cli-bundle/pom.xml: ########## @@ -0,0 +1,275 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi</artifactId> + <groupId>org.apache.hudi</groupId> + <version>0.13.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hudi-cli-bundle_${scala.binary.version}</artifactId> + <packaging>jar</packaging> + + <properties> + <checkstyle.skip>true</checkstyle.skip> + <main.basedir>${project.parent.basedir}</main.basedir> + <skipTests>true</skipTests> + <javax.servlet.version>3.1.0</javax.servlet.version> + </properties> + + <build> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>${maven-shade-plugin.version}</version> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <createSourcesJar>${shadeSources}</createSourcesJar> + <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml + </dependencyReducedPomLocation> + <transformers> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer" /> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer"> + <addHeader>true</addHeader> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer"> + <resource>META-INF/LICENSE</resource> + <file>target/classes/META-INF/LICENSE</file> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.handlers</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.schemas</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.factories</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/> + <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> + <mainClass>org.apache.hudi.cli.Main</mainClass> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.actuate.autoconfigure.web.ManagementContextConfiguration.imports</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports</resource> + </transformer> + </transformers> + <artifactSet> + <includes combine.children="append"> + <include>org.apache.hudi:hudi-cli</include> + <include>org.apache.hudi:hudi-utilities_${scala.binary.version}</include> + + <!-- cli related dependencies --> + <include>org.springframework*:*</include> + <include>org.springframework.boot:*</include> + <include>org.apache.logging.log4j:*</include> + <include>org.scala-lang:scala-library</include> + <include>org.apache.parquet:parquet-hadoop</include> + <include>com.google.guava:guava</include> + <include>org.apache.httpcomponents:httpclient</include> + <include>org.apache.httpcomponents:httpcore</include> + <include>org.apache.httpcomponents:fluent-hc</include> + <include>org.jline:*</include> + <include>org.yaml:*</include> + <include>commons-logging:*</include> + <include>org.apache.avro:avro</include> Review Comment: I believe this can be removed as it can vary across different Spark versions. ########## packaging/hudi-cli-bundle/pom.xml: ########## @@ -0,0 +1,275 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi</artifactId> + <groupId>org.apache.hudi</groupId> + <version>0.13.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>hudi-cli-bundle_${scala.binary.version}</artifactId> + <packaging>jar</packaging> + + <properties> + <checkstyle.skip>true</checkstyle.skip> + <main.basedir>${project.parent.basedir}</main.basedir> + <skipTests>true</skipTests> + <javax.servlet.version>3.1.0</javax.servlet.version> + </properties> + + <build> + <plugins> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>${maven-shade-plugin.version}</version> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <createSourcesJar>${shadeSources}</createSourcesJar> + <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml + </dependencyReducedPomLocation> + <transformers> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer" /> + <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer"> + <addHeader>true</addHeader> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.IncludeResourceTransformer"> + <resource>META-INF/LICENSE</resource> + <file>target/classes/META-INF/LICENSE</file> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.handlers</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.schemas</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring.factories</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/> + <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer"> + <mainClass>org.apache.hudi.cli.Main</mainClass> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.actuate.autoconfigure.web.ManagementContextConfiguration.imports</resource> + </transformer> + <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> + <resource>META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports</resource> + </transformer> + </transformers> + <artifactSet> + <includes combine.children="append"> + <include>org.apache.hudi:hudi-cli</include> + <include>org.apache.hudi:hudi-utilities_${scala.binary.version}</include> + + <!-- cli related dependencies --> + <include>org.springframework*:*</include> Review Comment: Could you sort the list of `<include>` for CLI for better readability? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
