leesf commented on code in PR #7339:
URL: https://github.com/apache/hudi/pull/7339#discussion_r1036601606
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -62,6 +62,11 @@ object DataSourceReadOptions {
"(or) Read Optimized mode (obtain latest view, based on base files) (or)
Snapshot mode " +
"(obtain latest view, by merging base and (if any) log files)")
+ val QUERY_USE_DATABASE: ConfigProperty[Boolean] = ConfigProperty
+ .key("hoodie.query.use.database")
Review Comment:
If it only affect incremental query, maybe
`hoodie.query.incremental.database` is a better name? or it is also affect
other types of query? then we need to add more test cases.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -62,6 +62,11 @@ object DataSourceReadOptions {
"(or) Read Optimized mode (obtain latest view, based on base files) (or)
Snapshot mode " +
"(obtain latest view, by merging base and (if any) log files)")
+ val QUERY_USE_DATABASE: ConfigProperty[Boolean] = ConfigProperty
+ .key("hoodie.query.use.database")
Review Comment:
If it only affects incremental query, maybe
`hoodie.query.incremental.database` is a better name? or it is also affect
other types of query? then we need to add more test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
