minihippo commented on code in PR #5064:
URL: https://github.com/apache/hudi/pull/5064#discussion_r1036993600


##########
.gitignore:
##########
@@ -1,6 +1,7 @@
 # Directories #
 /build/
 target/
+hudi-metaserver/src/main/thrift/gen-java/

Review Comment:
   I move the thrift source code to the `target`, but it introduces a new 
problem that developer has to compile the thrift code before mvn clean. It has 
no effect for develop who has thrift binary at local. It's inconvenient for 
others who use docker to do this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to