danny0405 commented on code in PR #6915:
URL: https://github.com/apache/hudi/pull/6915#discussion_r1037755466
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -120,6 +122,7 @@ public Set<ConfigOption<?>> optionalOptions() {
*/
private void sanityCheck(Configuration conf, ResolvedSchema schema) {
List<String> fields = schema.getColumnNames();
+ Schema inferredSchema =
AvroSchemaConverter.convertToSchema(schema.toPhysicalRowDataType().notNull().getLogicalType());
Review Comment:
There is no need to convert the `ResolvedSchema` as an avro schema for
validation, the `ResolvedSchema#getColumnDataTypes` can fetch the data type of
each field.
Also we need to fix the `RowDataKeyGen#getRecordKey` for nested primary keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
