xushiyan commented on pull request #1607: URL: https://github.com/apache/incubator-hudi/pull/1607#issuecomment-626212331
@yanghua this is ready for review. thank you. To note a few - `hudi-spark/src/test/java/HoodieJavaApp.java` and `hudi-spark/src/test/java/HoodieJavaStreamingApp.java` are for docker run and integ tests hence leave them as is. - hudi-spark module is supposed to have package name `org.apache.hudi.spark` but it is `org.apache.hudi`. I'm not inclined to change it in this PR as this involves changing the src/main packages too. Hence I only aligned the test package with the src not changing both. - `hudi-utilities/src/test/java/org/apache/hudi/utilities/inline/fs/TestParquetInLining.java` is an outlier in `hudi-utilities` as its docs explained, it was supposed to be in `hudi-common` but needs HoodieTestDataGenerator which is in `hudi-client` hence it was placed in `hudi-utilities`. I left it as it due to this needing changes to `HoodieTestDataGenerator` in a bigger scope. These are the points that not reflected in the diff. Let me know if you have different views. cc @vinothchandar ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
