Zouxxyy commented on code in PR #7374:
URL: https://github.com/apache/hudi/pull/7374#discussion_r1040446879


##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -150,8 +151,8 @@ object HoodieDatasetBulkInsertHelper extends Logging {
       }
 
       writer.getWriteStatuses.asScala.map(_.toWriteStatus).iterator
-    }).collect()
-    table.getContext.parallelize(writeStatuses.toList.asJava)

Review Comment:
   @boneanxs 
   First, RDD recalculation is a BUG, we can't add collect here because of it
   We need to fix it, with reference to your comments, I modified #7373, try 
persist writeStatusRDD
   
   For, #7343, you should be right, I overlooked that other operations may also 
generate a task. However, I'm wondering if it's necessary to specifically set a 
parameter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to