alexeykudinkin commented on code in PR #5834:
URL: https://github.com/apache/hudi/pull/5834#discussion_r1042826277
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileReader.java:
##########
@@ -343,16 +344,18 @@ private static GenericRecord deserialize(final byte[]
keyBytes,
final byte[] valueBytes,
Schema writerSchema,
Schema readerSchema) throws
IOException {
- GenericRecord record = HoodieAvroUtils.bytesToAvro(valueBytes,
writerSchema, readerSchema);
+ GenericRecord wRecord = HoodieAvroUtils.bytesToAvro(valueBytes,
writerSchema);
+ GenericData.Record rRecord = new GenericData.Record(readerSchema);
Review Comment:
I don't think this is the right place to implement this -- we need to be
handle schema evolution holistically, not just for HFile reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
