vinothchandar commented on a change in pull request #1608:
URL: https://github.com/apache/incubator-hudi/pull/1608#discussion_r422642219



##########
File path: hudi-common/pom.xml
##########
@@ -204,5 +204,18 @@
       <scope>test</scope>
     </dependency>
 
+
+    <!-- alluxio -->

Review comment:
       this seems to be done, just to get the class name programmatically?  Can 
we not take this dependency? (we have kept it that way for all the `fs` impl so 
far, if we want to change it, then need to change/add testing etc uniformly, 
which is a separate body of work/jira IMHO)>

##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java
##########
@@ -45,7 +45,9 @@
   // Aliyun OSS
   OSS("oss", false),
   // View FS for federated setups. If federating across cloud stores, then 
append support is false
-  VIEWFS("viewfs", true);
+  VIEWFS("viewfs", true),
+  //ALLUXIO
+  ALLUXIO("alluxio",true);

Review comment:
       Alluxio supports append? Thats a good surprise :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to