hbgstc123 commented on code in PR #7408:
URL: https://github.com/apache/hudi/pull/7408#discussion_r1044035426
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/NonThrownExecutor.java:
##########
@@ -136,15 +136,15 @@ private <E extends Throwable> Runnable wrapAction(
}
private void handleException(Throwable t, ExceptionHook hook,
Supplier<String> actionString) {
+ final String errMsg = String.format("Executor executes action [%s] error",
actionString.get());
+ if (hook != null) {
+ hook.apply(errMsg, t);
+ }
// if we have a JVM critical error, promote it immediately, there is a good
// chance the
// logging or job failing will not succeed any more
ExceptionUtils.rethrowIfFatalErrorOrOOM(t);
- final String errMsg = String.format("Executor executes action [%s] error",
actionString.get());
logger.error(errMsg, t);
- if (hook != null) {
Review Comment:
thanks for review, moved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
