chenshzh commented on code in PR #5950:
URL: https://github.com/apache/hudi/pull/5950#discussion_r1044074034


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -97,8 +97,6 @@ public void close() {
   public void bootstrap(HoodieTableMetaClient metaClient) throws IOException {
     fs.delete(path, true);
     fs.mkdirs(path);
-    
metaClient.getActiveTimeline().getCommitsTimeline().filterPendingExcludingCompaction()
-        .lastInstant().ifPresent(instant -> 
startInstant(instant.getTimestamp()));

Review Comment:
   @leesf shall we consider this related 
PR?https://github.com/apache/hudi/pull/5913 
   It will re-send pending instants to ckp_meta when bootstrap, and introduce a 
mechanism of CANCELLED state to eliminate rollbacked instants. 
   Thus last successful instant will be kept when recovering for recommit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to