SteNicholas commented on code in PR #7403:
URL: https://github.com/apache/hudi/pull/7403#discussion_r1044396430
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/streamer/HoodieFlinkStreamer.java:
##########
@@ -99,12 +99,23 @@ public static void main(String[] args) throws Exception {
}
OptionsInference.setupSinkTasks(conf, env.getParallelism());
- DataStream<HoodieRecord> hoodieRecordDataStream =
Pipelines.bootstrap(conf, rowType, dataStream);
- DataStream<Object> pipeline = Pipelines.hoodieStreamWrite(conf,
hoodieRecordDataStream);
- if (OptionsResolver.needsAsyncCompaction(conf)) {
- Pipelines.compact(conf, pipeline);
+ DataStream<Object> pipeline;
+ // Append mode
+ if (OptionsResolver.isAppendMode(conf)) {
+ pipeline = Pipelines.append(conf, rowType, dataStream, false);
+ if (OptionsResolver.needsAsyncClustering(conf)) {
+ Pipelines.cluster(conf, rowType, pipeline);
+ } else {
+ Pipelines.dummySink(pipeline);
+ }
} else {
- Pipelines.clean(conf, pipeline);
+ DataStream<HoodieRecord> hoodieRecordDataStream =
Pipelines.bootstrap(conf, rowType, dataStream);
+ pipeline = Pipelines.hoodieStreamWrite(conf, hoodieRecordDataStream);
+ if (OptionsResolver.needsAsyncCompaction(conf)) {
+ Pipelines.compact(conf, pipeline);
+ } else {
+ Pipelines.clean(conf, pipeline);
Review Comment:
@leesf, there is no case that the compaction and clean co-exists for older
logic. Current logic is consistent with the `Pipelines` in `HoodieTableSink`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
