yihua commented on code in PR #7402:
URL: https://github.com/apache/hudi/pull/7402#discussion_r1044720487


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertSortMode.java:
##########
@@ -22,7 +22,8 @@
  * Bulk insert sort mode.
  */
 public enum BulkInsertSortMode {
-    NONE,
-    GLOBAL_SORT,
-    PARTITION_SORT
+  NONE,
+  GLOBAL_SORT,
+  PARTITION_SORT,
+  PARTITION_PATH_REDISTRIBUTE

Review Comment:
   The reason to use `REDISTRIBUTE` is the new sort mode only does repartition 
for partitioned tables, not for non-partitioned tables, so I don't want to give 
the impression that the repartition is also done for non-partitioned tables.  
But I understand your point that we'd like to call out repartition.  How about 
`PARTITION_PATH_SORT`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to