codope commented on code in PR #7437:
URL: https://github.com/apache/hudi/pull/7437#discussion_r1046622218
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -752,6 +752,7 @@ public void
dropMetadataPartitions(List<MetadataPartitionType> metadataPartition
LOG.warn("Deleting pending indexing instant from the timeline for
partition: " + partitionPath);
deletePendingIndexingInstant(dataMetaClient, partitionPath);
}
+ closeInternal();
}
Review Comment:
`HoodieBackedTableMetadataWriter` extends `HoodieTableMetadataWriter` which
implements `AutoClosable`. But yeah we could create the writer in
try-with-resource.
+1 for fixing `HoodieFlinkWriteClient` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
