[
https://issues.apache.org/jira/browse/HUDI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646866#comment-17646866
]
Ethan Guo commented on HUDI-5169:
---------------------------------
The logic is here in BaseHoodieWriteClient
{code:java}
protected Boolean rollbackFailedWrites(boolean skipLocking) {
HoodieTable<T, I, K, O> table = createTable(config, hadoopConf);
List<String> instantsToRollback =
getInstantsToRollback(table.getMetaClient(),
config.getFailedWritesCleanPolicy(), Option.empty());
Map<String, Option<HoodiePendingRollbackInfo>> pendingRollbacks =
getPendingRollbackInfos(table.getMetaClient());
instantsToRollback.forEach(entry -> pendingRollbacks.putIfAbsent(entry,
Option.empty()));
rollbackFailedWrites(pendingRollbacks, skipLocking);
return true;
} {code}
> Re-attempt failed rollback (regular commits, clustering) and get it to
> completion
> ---------------------------------------------------------------------------------
>
> Key: HUDI-5169
> URL: https://issues.apache.org/jira/browse/HUDI-5169
> Project: Apache Hudi
> Issue Type: Improvement
> Components: writer-core
> Reporter: sivabalan narayanan
> Assignee: Ethan Guo
> Priority: Blocker
> Fix For: 0.13.0
>
>
> If rollback removed the commit to be rolled back, but failed to complete, we
> may never get to complete it. bcoz, the original commit that needs to be
> rolledback is not seen in the timeline.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
