CTTY commented on code in PR #7224: URL: https://github.com/apache/hudi/pull/7224#discussion_r1048895751
########## packaging/hudi-cli-bundle/hudi-cli-with-bundle.sh: ########## @@ -0,0 +1,44 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" +echo "DIR is ${DIR}" +CLI_BUNDLE_JAR=`ls $DIR/target/hudi-cli-bundle*.jar | grep -v source | grep -v javadoc` +SPARK_BUNDLE_JAR=`ls $DIR/../hudi-spark-bundle/target/hudi-spark*-bundle*.jar | grep -v source | grep -v javadoc` +HUDI_CONF_DIR="${DIR}"/conf +# hudi aux lib contains jakarta.el jars, which need to be put directly on class path +HUDI_AUX_LIB="${DIR}"/auxlib + +. "${DIR}"/conf/hudi-env.sh + +if [ -z "$CLI_BUNDLE_JAR" ] || [ -z "$SPARK_BUNDLE_JAR" ]; then + echo "Make sure to generate both the hudi-cli-bundle.jar and hudi-spark-bundle.jar before running this script." Review Comment: nit: it might be better to have a seperate if for each bundle to display which is missing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
