[GitHub] [hudi] yihua commented on a diff in pull request #7493: Avoid file index and use fs view cache in COW input format

[GitBox]

yihua commented on code in PR #7493:
URL: https://github.com/apache/hudi/pull/7493#discussion_r1051360692


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieCopyOnWriteTableInputFormat.java:
##########
@@ -236,28 +249,53 @@ private List<FileStatus> 
listStatusForSnapshotMode(JobConf job,
       boolean shouldIncludePendingCommits =
           HoodieHiveUtils.shouldIncludePendingCommits(job, 
tableMetaClient.getTableConfig().getTableName());
 
-      HiveHoodieTableFileIndex fileIndex =
-          new HiveHoodieTableFileIndex(
-              engineContext,
-              tableMetaClient,
-              props,
-              HoodieTableQueryType.SNAPSHOT,
-              partitionPaths,
-              queryCommitInstant,
-              shouldIncludePendingCommits);
-
-      Map<String, List<FileSlice>> partitionedFileSlices = 
fileIndex.listFileSlices();
-
-      Option<HoodieVirtualKeyInfo> virtualKeyInfoOpt = 
getHoodieVirtualKeyInfo(tableMetaClient);
-
-      targetFiles.addAll(
-          partitionedFileSlices.values()
-              .stream()
-              .flatMap(Collection::stream)
-              .filter(fileSlice -> checkIfValidFileSlice(fileSlice))
-              .map(fileSlice -> createFileStatusUnchecked(fileSlice, 
fileIndex, virtualKeyInfoOpt))
-              .collect(Collectors.toList())
-      );
+      if (conf.getBoolean(ENABLE.key(), DEFAULT_METADATA_ENABLE_FOR_READERS) 
&& HoodieTableMetadataUtil.isFilesPartitionAvailable(tableMetaClient)) {
+        HiveHoodieTableFileIndex fileIndex =
+            new HiveHoodieTableFileIndex(
+                engineContext,
+                tableMetaClient,
+                props,
+                HoodieTableQueryType.SNAPSHOT,
+                partitionPaths,
+                queryCommitInstant,
+                shouldIncludePendingCommits);
+
+        Map<String, List<FileSlice>> partitionedFileSlices = 
fileIndex.listFileSlices();
+
+        Option<HoodieVirtualKeyInfo> virtualKeyInfoOpt = 
getHoodieVirtualKeyInfo(tableMetaClient);
+
+        targetFiles.addAll(
+            partitionedFileSlices.values()
+                .stream()
+                .flatMap(Collection::stream)
+                .filter(fileSlice -> checkIfValidFileSlice(fileSlice))
+                .map(fileSlice -> createFileStatusUnchecked(fileSlice, 
fileIndex, virtualKeyInfoOpt))
+                .collect(Collectors.toList())
+        );
+      } else {
+        HoodieTimeline timeline = tableMetaClient.getActiveTimeline();
+
+        try {
+          HoodieTableFileSystemView fsView = 
fsViewCache.computeIfAbsent(tableMetaClient, hoodietableMetaClient ->

Review Comment:
   +1 Essentially, this is the old logic from 0.8.0 release, which the fallback 
when metadata table is not used: 
https://github.com/apache/hudi/blob/release-0.8.0/hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java#L443



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org