jonvex commented on code in PR #7413:
URL: https://github.com/apache/hudi/pull/7413#discussion_r1051423297
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala:
##########
@@ -1046,4 +1048,62 @@ class TestInsertTable extends HoodieSparkSqlTestBase {
)
}
}
+
+ /**
+ * This test is to make sure that bulk insert doesn't create a bunch of tiny
files if
+ * hoodie.bulkinsert.user.defined.partitioner.sort.columns doesn't start
with the partition columns
+ *
+ */
+ forAll(BulkInsertSortMode.values().toList) { (sortMode: BulkInsertSortMode)
=>
+ val sortModeName = sortMode.name()
+ test(s"Test Bulk Insert with BulkInsertSortMode: '$sortModeName'") {
Review Comment:
I did this when I made TestSparkSqlCoreFlow and it seems to work. It is a
bit annoying that you need to comment out the other tests in the class if you
just want to run this test, but when we made the core flow test, it seemed to
be the best way to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
