alexeykudinkin commented on code in PR #7506:
URL: https://github.com/apache/hudi/pull/7506#discussion_r1052614861
##########
azure-pipelines.yml:
##########
@@ -19,7 +19,7 @@ trigger:
- '*' # must quote since "*" is a YAML reserved character; we want a
string
pool:
- vmImage: 'ubuntu-18.04'
+ vmImage: 'ubuntu-20.04'
Review Comment:
Why not 22 actually (as title claims)?
##########
hudi-spark-datasource/hudi-spark/pom.xml:
##########
@@ -56,6 +56,10 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>1.8</source>
Review Comment:
Good catch! Should we propagate this configs to every module?
Let's also parameterize actual version so it's easier to change from the
main pom
##########
hudi-spark-datasource/hudi-spark/pom.xml:
##########
@@ -274,11 +278,23 @@
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Please add a comment elaborating on why we need this setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
