leesf commented on a change in pull request #1624:
URL: https://github.com/apache/incubator-hudi/pull/1624#discussion_r425183331



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -294,6 +318,18 @@ private static int rollbackToSavepoint(JavaSparkContext 
jsc, String savepointTim
     }
   }
 
+  private static int deleteSavepoint(JavaSparkContext jsc, String 
savepointTime, String basePath) throws Exception {
+    HoodieWriteClient client = createHoodieClient(jsc, basePath);
+    try {
+      client.deleteSavepoint(savepointTime);
+      LOG.info(String.format("Savepoint \"%s\" deleted.", savepointTime));
+      return 0;
+    } catch (Exception e) {
+      LOG.info(String.format("Failed: Could not delete savepoint \"%s\".", 
savepointTime));
+      return -1;

Review comment:
       this returns -1.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to