zhuanshenbsj1 commented on code in PR #7405:
URL: https://github.com/apache/hudi/pull/7405#discussion_r1057306015
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -455,6 +458,10 @@ private Stream<HoodieInstant> getCommitInstantsToArchive()
{
}
return true;
}).filter(s ->
+ earlestUnCleanCompletedInstant.map(instant ->
+ compareTimestamps(instant.getTimestamp(), GREATER_THAN,
s.getTimestamp()))
+ .orElse(true)
+ ).filter(s ->
Review Comment:
> We better check the timeline clean metadata files, only when all the
replaced clustering files are cleaned, can the clustering instant be archived.
no completed clustering instant -> no need to check
firstCompletedClusteringInstant is not null && no completed clean instant ->
return firstCompletedClusteringInstant
firstCompletedClusteringInstant is not null && earliestCleanInstant is not
null -> return firstUncleanClusteringInstant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
