allenerb commented on pull request #1597: URL: https://github.com/apache/incubator-hudi/pull/1597#issuecomment-628853876
Hi Vinoth, Apologies for not getting back to this PR to make changes. I’ve been swamped trying to get Hudi working in the environment (still struggling with it). I don’t mind at all going in and trying to merge the thing, but at the moment I’m spending all my time trying to figure this thing out! :-) If you’re ok with taking it as-is at the moment, I’d definitely sign up for updating it in the near future, but I do think the idea of merging the two made a lot of sense. I also saw your email about trying to get the PR backlog wrapped up for release 0.5.3 so I’m good with whatever you decide. I don’t want to be your bottleneck right now. Allen On Thu, May 14, 2020 at 3:32 PM vinoth chandar <notificati...@github.com> wrote: > @allenerb <https://github.com/allenerb> Trying to understand the next > steps here.. Are we deciding between doing a separate class and merging > this into the existing class? > > I am happy to take the patch as-is and do the consolidation as follow on > work as well. let me know what you both think cc @pratyakshsharma > <https://github.com/pratyakshsharma> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-hudi/pull/1597#issuecomment-628843862>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABSXVVZXCRGS65VAFXTXY7DRRRBMHANCNFSM4M2WO5MQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org