xushiyan commented on code in PR #7564:
URL: https://github.com/apache/hudi/pull/7564#discussion_r1057748910
##########
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncClient.java:
##########
@@ -125,11 +126,10 @@ public List<String>
getWrittenPartitionsSince(Option<String> lastCommitTimeSynce
config.getBoolean(META_SYNC_ASSUME_DATE_PARTITION));
} else {
LOG.info("Last commit time synced is " + lastCommitTimeSynced.get() + ",
Getting commits since then");
- return TimelineUtils.getWrittenPartitions(
- metaClient.getArchivedTimeline(lastCommitTimeSynced.get())
- .mergeTimeline(metaClient.getActiveTimeline())
- .getCommitsTimeline()
- .findInstantsAfter(lastCommitTimeSynced.get(),
Integer.MAX_VALUE));
+ final HoodieDefaultTimeline timeline =
metaClient.getActiveTimeline().isBeforeTimelineStarts(lastCommitTimeSynced.get())
+ ?
metaClient.getArchivedTimeline(lastCommitTimeSynced.get()).mergeTimeline(metaClient.getActiveTimeline())
+ : metaClient.getActiveTimeline();
+ return
TimelineUtils.getWrittenPartitions(timeline.getCommitsTimeline().findInstantsAfter(lastCommitTimeSynced.get(),
Integer.MAX_VALUE));
Review Comment:
similar logic can be applied to `getDroppedPartitionsSince()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
