xushiyan commented on code in PR #6732:
URL: https://github.com/apache/hudi/pull/6732#discussion_r1057816433
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -188,6 +188,7 @@ public static HoodieTableMetaClient initTableIfNotExists(
.setTableCreateSchema(conf.getString(FlinkOptions.SOURCE_AVRO_SCHEMA))
.setTableType(conf.getString(FlinkOptions.TABLE_TYPE))
.setTableName(conf.getString(FlinkOptions.TABLE_NAME))
+ .setDatabaseName(conf.getString(FlinkOptions.DATABASE_NAME))
Review Comment:
is this fixing a separate bug?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java:
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.model.ActionType;
+
+import javax.annotation.concurrent.Immutable;
+
+import java.util.Properties;
+
+/**
+ * Configurations used by the Hudi Table Service Manager.
+ */
+@Immutable
+@ConfigClassProperty(name = "Table Service Manager Configs",
+ groupName = ConfigGroups.Names.WRITE_CLIENT,
+ description = "Configurations used by the Hudi Table Service Manager.")
+public class HoodieTableServiceManagerConfig extends HoodieConfig {
+
+ public static final String TABLE_SERVICE_MANAGER_PREFIX =
"hoodie.table.service.manager";
+
+ public static final ConfigProperty<Boolean> TABLE_SERVICE_MANAGER_ENABLE =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".enable")
+ .defaultValue(false)
+ .withDocumentation("Use table manager service to execute table service");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_URIS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".uris")
+ .defaultValue("http://localhost:9091";)
+ .withDocumentation("Table service manager uris");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_ACTIONS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".actions")
+ .defaultValue("")
Review Comment:
should make it `noDefaultValue()` if nothing should be the default
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -84,6 +84,12 @@ private FlinkOptions() {
// Common Options
// ------------------------------------------------------------------------
+ public static final ConfigOption<String> DATABASE_NAME = ConfigOptions
+ .key(HoodieTableConfig.DATABASE_NAME.key())
+ .stringType()
+ .noDefaultValue()
+ .withDescription("Database name to register to Hive metastore");
Review Comment:
can we separate this from refactoring changes?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java:
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.model.ActionType;
+
+import javax.annotation.concurrent.Immutable;
+
+import java.util.Properties;
+
+/**
+ * Configurations used by the Hudi Table Service Manager.
+ */
+@Immutable
+@ConfigClassProperty(name = "Table Service Manager Configs",
+ groupName = ConfigGroups.Names.WRITE_CLIENT,
+ description = "Configurations used by the Hudi Table Service Manager.")
+public class HoodieTableServiceManagerConfig extends HoodieConfig {
+
+ public static final String TABLE_SERVICE_MANAGER_PREFIX =
"hoodie.table.service.manager";
+
+ public static final ConfigProperty<Boolean> TABLE_SERVICE_MANAGER_ENABLE =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".enable")
+ .defaultValue(false)
+ .withDocumentation("Use table manager service to execute table service");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_URIS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".uris")
+ .defaultValue("http://localhost:9091";)
+ .withDocumentation("Table service manager uris");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_ACTIONS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".actions")
+ .defaultValue("")
+ .withDocumentation("Which action deploy on table service manager such as
compaction:clean, default null");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_USERNAME = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.username")
+ .defaultValue("default")
+ .withDocumentation("The user name to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_QUEUE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.queue")
+ .defaultValue("default")
+ .withDocumentation("The queue to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_RESOURCE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.resource")
+ .defaultValue("4g:4g")
+ .withDocumentation("The resource to deploy for table service of this
table, default driver 4g, executor 4g");
Review Comment:
this is specific to spark. so this string of resources representation is
only parseable under the context of the engine? how about making it
`spark:4g,4g` so we can merge the engine config into this
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java:
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.model.ActionType;
+
+import javax.annotation.concurrent.Immutable;
+
+import java.util.Properties;
+
+/**
+ * Configurations used by the Hudi Table Service Manager.
+ */
+@Immutable
+@ConfigClassProperty(name = "Table Service Manager Configs",
+ groupName = ConfigGroups.Names.WRITE_CLIENT,
+ description = "Configurations used by the Hudi Table Service Manager.")
+public class HoodieTableServiceManagerConfig extends HoodieConfig {
+
+ public static final String TABLE_SERVICE_MANAGER_PREFIX =
"hoodie.table.service.manager";
+
+ public static final ConfigProperty<Boolean> TABLE_SERVICE_MANAGER_ENABLE =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".enable")
+ .defaultValue(false)
+ .withDocumentation("Use table manager service to execute table service");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_URIS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".uris")
+ .defaultValue("http://localhost:9091";)
+ .withDocumentation("Table service manager uris");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_ACTIONS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".actions")
+ .defaultValue("")
+ .withDocumentation("Which action deploy on table service manager such as
compaction:clean, default null");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_USERNAME = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.username")
+ .defaultValue("default")
+ .withDocumentation("The user name to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_QUEUE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.queue")
+ .defaultValue("default")
+ .withDocumentation("The queue to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_RESOURCE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.resource")
+ .defaultValue("4g:4g")
+ .withDocumentation("The resource to deploy for table service of this
table, default driver 4g, executor 4g");
+
+ public static final ConfigProperty<Integer>
TABLE_SERVICE_MANAGER_DEPLOY_PARALLELISM = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.parallelism")
+ .defaultValue(100)
+ .withDocumentation("The max parallelism to deploy for table service of
this table, default 100");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_EXECUTION_ENGINE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".execution.engine")
+ .defaultValue("spark")
+ .withDocumentation("The execution engine to deploy for table service of
this table, default spark");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_EXTRA_PARAMS = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.extra.params")
+ .defaultValue("")
+ .withDocumentation("The extra params to deploy for table service of this
table, split by ';'");
+
+ public static final ConfigProperty<Integer> TABLE_SERVICE_MANAGER_TIMEOUT =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".timeout")
+ .defaultValue(300)
+ .withDocumentation("Connection timeout for client");
+
+ public static final ConfigProperty<Integer> TABLE_SERVICE_MANAGER_RETRIES =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".connect.retries")
+ .defaultValue(3)
+ .withDocumentation("Number of retries while opening a connection to
table service manager");
+
+ public static final ConfigProperty<Integer>
TABLE_SERVICE_MANAGER_RETRY_DELAY = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".connect.retry.delay")
+ .defaultValue(1)
+ .withDocumentation("Number of seconds for the client to wait between
consecutive connection attempts");
+
+ public static final ConfigProperty<String> RETRY_EXCEPTIONS = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".operation.retry.exceptions")
+ .defaultValue("IOException")
+ .withDocumentation("The class name of the Exception that needs to be
re-tryed, separated by commas. "
+ + "Default is empty which means retry all the IOException and
RuntimeException from FileSystem");
+
+ public static final ConfigProperty<Integer>
TABLE_SERVICE_MANAGER_TOLERABLE_NUM = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".tolerable.num")
+ .defaultValue(0)
+ .withDocumentation("Number of connection to table manager service
unsuccessful tolerable for the client");
Review Comment:
this needs renaming. but first, can you clarify what will happen when number
of unsuccessful connections reaches the threshold?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTableServiceManagerClient.java:
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client;
+
+import org.apache.hudi.common.config.HoodieTableServiceManagerConfig;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.util.ClusteringUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.RetryHelper;
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.common.util.ValidationUtils;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieRemoteException;
+
+import org.apache.http.client.fluent.Request;
+import org.apache.http.client.utils.URIBuilder;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * Client which send the table service instants to the table service manager.
+ */
+public class HoodieTableServiceManagerClient {
+
+ /**
+ * Rollback commands, that trigger a specific handling for rollback.
+ */
Review Comment:
don't quite understand what this javadoc mean?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java:
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.model.ActionType;
+
+import javax.annotation.concurrent.Immutable;
+
+import java.util.Properties;
+
+/**
+ * Configurations used by the Hudi Table Service Manager.
+ */
+@Immutable
+@ConfigClassProperty(name = "Table Service Manager Configs",
+ groupName = ConfigGroups.Names.WRITE_CLIENT,
+ description = "Configurations used by the Hudi Table Service Manager.")
+public class HoodieTableServiceManagerConfig extends HoodieConfig {
+
+ public static final String TABLE_SERVICE_MANAGER_PREFIX =
"hoodie.table.service.manager";
+
+ public static final ConfigProperty<Boolean> TABLE_SERVICE_MANAGER_ENABLE =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".enable")
+ .defaultValue(false)
+ .withDocumentation("Use table manager service to execute table service");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_URIS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".uris")
+ .defaultValue("http://localhost:9091";)
+ .withDocumentation("Table service manager uris");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_ACTIONS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".actions")
+ .defaultValue("")
+ .withDocumentation("Which action deploy on table service manager such as
compaction:clean, default null");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_USERNAME = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.username")
+ .defaultValue("default")
+ .withDocumentation("The user name to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_QUEUE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.queue")
+ .defaultValue("default")
+ .withDocumentation("The queue to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_RESOURCE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.resource")
+ .defaultValue("4g:4g")
+ .withDocumentation("The resource to deploy for table service of this
table, default driver 4g, executor 4g");
+
+ public static final ConfigProperty<Integer>
TABLE_SERVICE_MANAGER_DEPLOY_PARALLELISM = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.parallelism")
+ .defaultValue(100)
+ .withDocumentation("The max parallelism to deploy for table service of
this table, default 100");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_EXECUTION_ENGINE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".execution.engine")
+ .defaultValue("spark")
+ .withDocumentation("The execution engine to deploy for table service of
this table, default spark");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_EXTRA_PARAMS = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.extra.params")
+ .defaultValue("")
+ .withDocumentation("The extra params to deploy for table service of this
table, split by ';'");
+
+ public static final ConfigProperty<Integer> TABLE_SERVICE_MANAGER_TIMEOUT =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".timeout")
+ .defaultValue(300)
+ .withDocumentation("Connection timeout for client");
+
+ public static final ConfigProperty<Integer> TABLE_SERVICE_MANAGER_RETRIES =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".connect.retries")
+ .defaultValue(3)
+ .withDocumentation("Number of retries while opening a connection to
table service manager");
+
+ public static final ConfigProperty<Integer>
TABLE_SERVICE_MANAGER_RETRY_DELAY = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".connect.retry.delay")
+ .defaultValue(1)
+ .withDocumentation("Number of seconds for the client to wait between
consecutive connection attempts");
+
+ public static final ConfigProperty<String> RETRY_EXCEPTIONS = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".operation.retry.exceptions")
+ .defaultValue("IOException")
Review Comment:
shouldn't the class name be fully qualified?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTableServiceManagerConfig.java:
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.config;
+
+import org.apache.hudi.common.model.ActionType;
+
+import javax.annotation.concurrent.Immutable;
+
+import java.util.Properties;
+
+/**
+ * Configurations used by the Hudi Table Service Manager.
+ */
+@Immutable
+@ConfigClassProperty(name = "Table Service Manager Configs",
+ groupName = ConfigGroups.Names.WRITE_CLIENT,
+ description = "Configurations used by the Hudi Table Service Manager.")
+public class HoodieTableServiceManagerConfig extends HoodieConfig {
+
+ public static final String TABLE_SERVICE_MANAGER_PREFIX =
"hoodie.table.service.manager";
+
+ public static final ConfigProperty<Boolean> TABLE_SERVICE_MANAGER_ENABLE =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".enable")
+ .defaultValue(false)
+ .withDocumentation("Use table manager service to execute table service");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_URIS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".uris")
+ .defaultValue("http://localhost:9091";)
+ .withDocumentation("Table service manager uris");
+
+ public static final ConfigProperty<String> TABLE_SERVICE_MANAGER_ACTIONS =
ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".actions")
+ .defaultValue("")
+ .withDocumentation("Which action deploy on table service manager such as
compaction:clean, default null");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_USERNAME = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.username")
+ .defaultValue("default")
+ .withDocumentation("The user name to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_QUEUE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.queue")
+ .defaultValue("default")
+ .withDocumentation("The queue to deploy for table service of this
table");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_RESOURCE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.resource")
+ .defaultValue("4g:4g")
+ .withDocumentation("The resource to deploy for table service of this
table, default driver 4g, executor 4g");
+
+ public static final ConfigProperty<Integer>
TABLE_SERVICE_MANAGER_DEPLOY_PARALLELISM = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.parallelism")
+ .defaultValue(100)
+ .withDocumentation("The max parallelism to deploy for table service of
this table, default 100");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_EXECUTION_ENGINE = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".execution.engine")
+ .defaultValue("spark")
+ .withDocumentation("The execution engine to deploy for table service of
this table, default spark");
+
+ public static final ConfigProperty<String>
TABLE_SERVICE_MANAGER_DEPLOY_EXTRA_PARAMS = ConfigProperty
+ .key(TABLE_SERVICE_MANAGER_PREFIX + ".deploy.extra.params")
+ .defaultValue("")
Review Comment:
can we make it `noDefaultValue()` if nothing should be default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
