vinothchandar commented on a change in pull request #1562:
URL: https://github.com/apache/incubator-hudi/pull/1562#discussion_r425421081
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroKafkaSource.java
##########
@@ -45,11 +46,14 @@
private final KafkaOffsetGen offsetGen;
+ private final String useCustomDeserializerProp =
"hoodie.deltastreamer.kafka.custom.avro.deserializer";
Review comment:
static string, all caps variable name?
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java
##########
@@ -106,6 +106,16 @@ public static SchemaProvider createSchemaProvider(String
schemaProviderClass, Ty
}
}
+ public static SchemaProvider createSchemaProvider(String schemaProviderClass,
+ TypedProperties cfg)
throws IOException {
+ try {
+ return schemaProviderClass == null ? null :
+ (SchemaProvider) ReflectionUtils.loadClass(schemaProviderClass, cfg);
+ } catch (Throwable e) {
+ throw new IOException("Could not load schema provider class " +
schemaProviderClass, e);
Review comment:
throw HoodieException instead?
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroKafkaSource.java
##########
@@ -23,6 +23,7 @@
import org.apache.hudi.utilities.schema.SchemaProvider;
import org.apache.hudi.utilities.sources.helpers.KafkaOffsetGen;
import
org.apache.hudi.utilities.sources.helpers.KafkaOffsetGen.CheckpointUtils;
+import org.apache.hudi.utilities.sources.serde.HoodieAvroKafkaDeserializer;
import io.confluent.kafka.serializers.KafkaAvroDeserializer;
Review comment:
@pratyakshsharma I thought this is what this deserializer does. no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
