yihua commented on code in PR #7517:
URL: https://github.com/apache/hudi/pull/7517#discussion_r1058593990


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -751,6 +756,7 @@ private void validateFileSlices(
     if (fileSliceListFromMetadataTable.size() != fileSliceListFromFS.size()) {
       mismatch = true;
     } else if (!fileSliceListFromMetadataTable.equals(fileSliceListFromFS)) {
+      Map<String, Set<String>> committedFilesMap = new HashMap<>();

Review Comment:
   `committedFilesMap` serves as an in-memory cache for the set of committed 
files of each commit.  We don't want to deserialize the same commit metadata 
repeatedly across multiple calls of `areFileSliceCommittedLogFilesMatching`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to