leesf commented on code in PR #7568:
URL: https://github.com/apache/hudi/pull/7568#discussion_r1058904972
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -432,6 +433,11 @@ private Stream<HoodieInstant> getCommitInstantsToArchive()
{
table.getActiveTimeline(),
config.getInlineCompactDeltaCommitMax())
: Option.empty();
+ // The clustering commit instant can not be archived unless we ensure
that the replaced files have been cleaned,
+ // without the replaced files metadata on the timeline, the fs view
would expose duplicates for readers.
+ Option<HoodieInstant> oldestInstantToRetainForClustering =
Review Comment:
this name is a little confused with
`oldestPendingCompactionAndReplaceInstant` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
