danny0405 commented on code in PR #7584:
URL: https://github.com/apache/hudi/pull/7584#discussion_r1060264789
##########
hudi-flink-datasource/hudi-flink1.13.x/src/main/java/org/apache/hudi/adapter/StreamWriteOperatorCoordinatorAdapter.java:
##########
@@ -0,0 +1,9 @@
+package org.apache.hudi.adapter;
+
+import org.apache.flink.runtime.operators.coordination.OperatorCoordinator;
+
+/**
+ * Bridge class for shaded guava clazz {@code StreamWriteOperatorCoordinator}.
+ */
Review Comment:
Rename the clazz to `OperatorCoordinatorAdapter`, the license header is also
missing.
##########
hudi-flink-datasource/hudi-flink1.13.x/src/main/java/org/apache/hudi/adapter/SortCodeGeneratorAdapter.java:
##########
@@ -0,0 +1,15 @@
+package org.apache.hudi.adapter;
+
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.planner.codegen.sort.SortCodeGenerator;
+import org.apache.flink.table.planner.plan.nodes.exec.spec.SortSpec;
+import org.apache.flink.table.types.logical.RowType;
+
+/**
+ * Bridge class for shaded guava clazz {@code SortCodeGenerator}.
+ */
Review Comment:
Remove `shaded guava`, the license header is missing.
##########
.github/workflows/bot.yml:
##########
@@ -95,6 +96,8 @@ jobs:
strategy:
matrix:
include:
+ - flinkProfile: 'flink1.16'
+ sparkProfile: 'spark3.3'
- flinkProfile: 'flink1.15'
sparkProfile: 'spark3.3'
Review Comment:
There are also 2 release scripts
1. `validate_staged_bundles.sh`
2. `deploy_staging_jars.sh`
that have hard coded flink versions, which should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
