LinMingQiang commented on code in PR #7469:
URL: https://github.com/apache/hudi/pull/7469#discussion_r1060370374
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -897,28 +897,40 @@ public HoodieCleanMetadata clean(String cleanInstantTime,
boolean scheduleInline
if (!tableServicesEnabled(config)) {
return null;
}
- final Timer.Context timerContext = metrics.getCleanCtx();
- CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
- HoodieTimeline.CLEAN_ACTION, () -> rollbackFailedWrites(skipLocking));
-
- HoodieTable table = createTable(config, hadoopConf);
- if (config.allowMultipleCleans() ||
!table.getActiveTimeline().getCleanerTimeline().filterInflightsAndRequested().firstInstant().isPresent())
{
- LOG.info("Cleaner started");
Review Comment:
Maybe we can add a special clean lock to ensure that only one cleaning
service is executing, skipping the current cleaning when the cleaning service
is executing, this is more efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
