bvaradar commented on a change in pull request #1518:
URL: https://github.com/apache/incubator-hudi/pull/1518#discussion_r425626686
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -460,8 +471,17 @@ private void syncHive() {
* this constraint.
*/
public void setupWriteClient() {
+ setupWriteClient(schemaProvider, false);
+ }
+
+ /**
+ * Note that depending on configs and source-type, schemaProvider could
either be eagerly or lazily created.
+ * SchemaProvider creation is a precursor to HoodieWriteClient and
AsyncCompactor creation. This method takes care of
+ * this constraint.
+ */
+ private void setupWriteClient(SchemaProvider schemaProvider, boolean
forceRecreate) {
LOG.info("Setting up Hoodie Write Client");
- if ((null != schemaProvider) && (null == writeClient)) {
+ if (forceRecreate || (null != schemaProvider) && (null == writeClient)) {
Review comment:
Actually, I just realized HoodieWriteConfig schema also needs to be
updated in this case. Trying to see if we can have a consistent point of
creating WriteClient and SchemaProvider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
