umehrot2 commented on pull request #1596: URL: https://github.com/apache/incubator-hudi/pull/1596#issuecomment-629169708
> LGTM overall.. If you can throw in a test, like you mentioned, that'd be great. > > Also trying to understand the scope of the issue.. without this, does every decimal type conversion fail? @vinothchandar every **decimal** conversion does not fail. As I understand from this PR, the NPE would occur when **decimal field** is not a **top level field** in the avro schema, but nested within another type. @rolandjohann is this understanding correct ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
