afeldman1 commented on issue #933:
URL: https://github.com/apache/incubator-hudi/issues/933#issuecomment-629455257
Thank you! That works. Should this be added to the org.apache.hudi
DataSourceOptions.scala?
Right now it has:
/**
* Key generator class, that implements will extract the key out of
incoming record
*
*/
val KEYGENERATOR_CLASS_OPT_KEY =
"hoodie.datasource.write.keygenerator.class"
val DEFAULT_KEYGENERATOR_CLASS_OPT_VAL =
classOf[SimpleKeyGenerator].getName
So we could add (open to opinions on the variable names):
val COMPLEX_KEYGENERATOR_CLASS_OPT_VAL = classOf[ComplexKeyGenerator].getName
val NOPARTITION_KEYGENERATOR_CLASS_OPT_VAL =
classOf[NonpartitionedKeyGenerator].getName
(I saw the no partition option being described in the FAQ wiki you linked to
above)
This would follow the pattern in the DataSourceWriteOptions object, so that
it's easier to see what options are available for the parameter. I haven't
contributed to this project yet, but if you agree about this change I can try
and add it in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
