danny0405 commented on code in PR #7626:
URL: https://github.com/apache/hudi/pull/7626#discussion_r1066607740
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java:
##########
@@ -94,7 +94,7 @@
* FileID to write handle mapping in order to record the write handles for
each file group,
* so that we can append the mini-batch data buffer incrementally.
*/
- private final Map<String, HoodieWriteHandle<?, ?, ?, ?>> bucketToHandles;
+ private final Map<String, MiniBatchHandle> bucketToHandles;
Review Comment:
We need to clarify whether `HoodieFlinkWriteClient#cleanHandlesGracefully`
is still valid. I wrote the logic to want it work like post task killing hook,
if a writing task was force killed when it is writing a file, how can we handle
this more gracefully.
For most of the case, if the writing task was force killed or canceled, the
file writer should had been closed right? I'm skeptical whether it is still
needed.
It is related with this issue, because if `cleanHandlesGracefully` is not
valid anymore, there is no need to cache any write handles at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
