danny0405 commented on code in PR #7637:
URL: https://github.com/apache/hudi/pull/7637#discussion_r1066634939
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/ITTestDataStreamWrite.java:
##########
@@ -554,4 +518,20 @@ public void testHoodiePipelineBuilderSinkWithSchemaSet()
throws Exception {
execute(execEnv, false, "Api_Sink_Test");
TestData.checkWrittenDataCOW(tempFile, EXPECTED);
}
+
+ private JsonDeserializationFunction getDeserializationFunc(Configuration
conf) {
+ // Read from file source
Review Comment:
Nice catch, curious why the CI does not fail for the PR previously, can we
move this `#getDeserializationFunc` into `JsonDeserializationFunction` and we
can have a static factory method like `JsonDeserializationFunction#getInstance`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
