yihua commented on code in PR #7619:
URL: https://github.com/apache/hudi/pull/7619#discussion_r1068462760
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -814,18 +820,22 @@ private void validateSchema() throws
HoodieUpsertException, HoodieInsertExceptio
}
public void validateUpsertSchema() throws HoodieUpsertException {
- try {
- validateSchema();
- } catch (HoodieException e) {
- throw new HoodieUpsertException("Failed upsert schema compatibility
check", e);
+ if (!isMetadataTable) {
+ try {
+ validateSchema();
+ } catch (HoodieException e) {
+ throw new HoodieUpsertException("Failed upsert schema compatibility
check", e);
+ }
}
}
public void validateInsertSchema() throws HoodieInsertException {
- try {
- validateSchema();
- } catch (HoodieException e) {
- throw new HoodieInsertException("Failed insert schema compatibility
check", e);
+ if (!isMetadataTable) {
+ try {
+ validateSchema();
+ } catch (HoodieException e) {
+ throw new HoodieInsertException("Failed insert schema compatibility
check", e);
+ }
}
}
Review Comment:
We have evolved the metadata payload schema before and there were cases
where the schema change is not backward compatible. Have you tested if
disabling schema validation is going to swallow the issue and cause corruption
of the metadata table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
