waywtdcc commented on code in PR #7295:
URL: https://github.com/apache/hudi/pull/7295#discussion_r1069106849
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/TableOptionProperties.java:
##########
@@ -113,6 +116,18 @@ public static void createProperties(String basePath,
*/
public static Map<String, String> loadFromProperties(String basePath,
Configuration hadoopConf) {
Path propertiesFilePath = getPropertiesFilePath(basePath);
+ return getPropsFromFile(basePath, hadoopConf, propertiesFilePath);
+ }
+
+ /**
+ * Read table options map from the given table base path.
+ */
+ public static Map<String, String> loadFromHoodiePropertieFile(String
basePath, Configuration hadoopConf) {
+ Path propertiesFilePath = getHoodiePropertiesFilePath(basePath);
+ return getPropsFromFile(basePath, hadoopConf, propertiesFilePath);
+ }
Review Comment:
Sorry, just saw it. Is it better to replace loadFromHoodiePropertieFile with
StreamerUtil.getTableConfig here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
