kazdy commented on code in PR #7668:
URL: https://github.com/apache/hudi/pull/7668#discussion_r1070182730


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -77,6 +77,28 @@ object HoodieSparkSqlWriter {
   private var asyncCompactionTriggerFnDefined: Boolean = false
   private var asyncClusteringTriggerFnDefined: Boolean = false
 
+  def changeOperationToInsertIfRequired(writeOperationType: 
WriteOperationType, hoodieConfig: HoodieConfig)

Review Comment:
   afaik in this case when changing op from upsert to insert one should also 
make sure that insert mode (SQL_INSERT_MODE) is set to "upsert", otherwise 
either duplicate record will be created (non-strict mode) or error will be 
thrown (strict mode)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to