pratyakshsharma commented on a change in pull request #1566:
URL: https://github.com/apache/incubator-hudi/pull/1566#discussion_r426184828
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -464,21 +464,25 @@ private void shutdownCompactor(boolean error) {
*/
protected Boolean onInitializingWriteClient(HoodieWriteClient writeClient)
{
if (cfg.isAsyncCompactionEnabled()) {
- asyncCompactService = new AsyncCompactService(jssc, writeClient);
- // Enqueue existing pending compactions first
- HoodieTableMetaClient meta =
- new HoodieTableMetaClient(new
Configuration(jssc.hadoopConfiguration()), cfg.targetBasePath, true);
- List<HoodieInstant> pending =
CompactionUtils.getPendingCompactionInstantTimes(meta);
- pending.forEach(hoodieInstant ->
asyncCompactService.enqueuePendingCompaction(hoodieInstant));
- asyncCompactService.start((error) -> {
- // Shutdown DeltaSync
- shutdown(false);
- return true;
- });
- try {
-
asyncCompactService.waitTillPendingCompactionsReducesTo(cfg.maxPendingCompactions);
- } catch (InterruptedException ie) {
- throw new HoodieException(ie);
+ if (null != asyncCompactService) {
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
