alexeykudinkin commented on code in PR #7582:
URL: https://github.com/apache/hudi/pull/7582#discussion_r1072998596
##########
hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorMessageQueue.java:
##########
@@ -60,6 +61,10 @@ public long size() {
@Override
public void insertRecord(I value) throws Exception {
+ if (!isStart) {
Review Comment:
@boneanxs we need to keep in mind that this lies on the hot-path of being
executed for every record, so we should keep the bar really high in terms of
what we allow to be executed for every record.
That being said, i also see your point of adding it to make sure it would
fail definitively unless queue has been started
##########
hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorMessageQueue.java:
##########
@@ -60,6 +61,10 @@ public long size() {
@Override
public void insertRecord(I value) throws Exception {
+ if (!isStart) {
Review Comment:
Let's keep it, please rename it to `isStarted`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
