yihua commented on code in PR #7612:
URL: https://github.com/apache/hudi/pull/7612#discussion_r1080888468
##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormatAppendFailure.java:
##########
@@ -134,7 +134,7 @@ public void testFailedToGetAppendStreamFromHDFSNameNode()
// Opening a new Writer right now will throw IOException. The code should
handle this, rollover the logfile and
// return a new writer with a bumped up logVersion
writer = HoodieLogFormat.newWriterBuilder().onParentPath(testPath)
-
.withFileExtension(HoodieArchivedLogFile.ARCHIVE_EXTENSION).withFileId("commits.archive")
+
.withFileExtension(HoodieArchivedLogFile.ARCHIVE_EXTENSION).withFileId("commits")
Review Comment:
does this mean the original tests do not properly construct the archived log
file name?
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -358,7 +358,7 @@ public static String createNewFileId(String idPfx, int id) {
* Get the file extension from the log file.
*/
public static String getFileExtensionFromLog(Path logPath) {
- Matcher matcher = LOG_FILE_PATTERN.matcher(logPath.getName());
+ Matcher matcher = LOG_FILE_PATTERN.matcher(logPath.getName());
Review Comment:
nit: remove spacing
##########
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java:
##########
@@ -306,7 +306,7 @@ protected void testInvalidLogFiles() throws Exception {
String fileName2 =
FSUtils.makeLogFileName(fileId, HoodieLogFile.DELTA_EXTENSION,
instantTime1, 1, TEST_WRITE_TOKEN);
// create a dummy log file mimicing cloud stores marker files
- String fileName3 = "_DUMMY_" + fileName1.substring(1, fileName1.length());
+ String fileName3 = "_GCS_SYNCABLE_TEMPFILE_" + fileName1;
Review Comment:
Could you add this as a new one test String besides `String fileName3 =
"_DUMMY_" + fileName1.substring(1, fileName1.length());`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
