yihua commented on code in PR #7528:
URL: https://github.com/apache/hudi/pull/7528#discussion_r1084396981
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala:
##########
@@ -138,10 +137,16 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
override protected def getPartitions: Array[Partition] =
fileSplits.zipWithIndex.map(file => HoodieMergeOnReadPartition(file._2,
file._1)).toArray
- private def getConfig: Configuration = {
- val conf = confBroadcast.value.value
- CONFIG_INSTANTIATION_LOCK.synchronized {
- new Configuration(conf)
- }
+ private def getHadoopConf: Configuration = {
+ val conf = hadoopConfBroadcast.value.value
+ new Configuration(conf)
Review Comment:
This lock is from the beginning of the implementation of
`HoodieMergeOnReadRDD` and it is likely due to the broadcast configuration
issue in Spark 2.4
(https://github.com/apache/hudi/pull/1848#issuecomment-666091024). @garyli1019
could you confirm if that's the case? I'd rather keep it and keep the code
safe from potentially breaking the MOR queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
