nsivabalan commented on PR #7668: URL: https://github.com/apache/hudi/pull/7668#issuecomment-1401111987
few high level points Dis-allow de-dup. If de-dup is enabled (combine before insert), we will fail the write. Siva: looks ok to me. Fail if "upsert" is set. With auto generation of record keys, we can't support upsert. I mean, every record is treated as a new record and so doing an index look up causes only unnecessary overhead. Siva: I feel we can automatically switch to insert. Its an impl detail. We anyways will document that auto generation of record keys is meant to be used only for immutable use-cases. So, rather than failing, I would prefer to auto switch to "insert". Fail if "hoodie.merge.allow.duplicate.on.inserts" is not enabled so that hudi does not unintentionaly de-dup due to small file handling. Siva: we should automatically enable this since this is more of an impl detail. I mean, we should not fail if user does not set this. Fail if someone choose to use MOR table type:- 2 reasons. a: there are no updates and so no point in choosing MOR. b: preCombine is a mandatory field w/ MOR table. but for table w/ auto generated record keys, precombine if not required to be set. Siva: seems ok. Fail if preCombine or recordkey field is set. Siva: seems ok to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
