danny0405 commented on code in PR #7445:
URL: https://github.com/apache/hudi/pull/7445#discussion_r1084820863
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveSyncClient.java:
##########
@@ -312,6 +314,16 @@ public void updateLastCommitTimeSynced(String tableName) {
if (lastCommitSynced.isPresent()) {
try {
Table table = client.getTable(databaseName, tableName);
+ String basePath = config.getString(META_SYNC_BASE_PATH);
+ StorageDescriptor sd = table.getSd();
+ sd.setLocation(basePath);
+ SerDeInfo serdeInfo = sd.getSerdeInfo();
+ Map<String, String> serdePathProperties =
SparkDataSourceTableUtils.getSparkSerdePathProperties(basePath);
+ for (Map.Entry<String, String> entry : serdePathProperties.entrySet())
{
Review Comment:
The `serdePathProperties` has only one entry, is it possible to eliminate
the for loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
