codope commented on code in PR #7740:
URL: https://github.com/apache/hudi/pull/7740#discussion_r1085546347
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1040,7 +1043,13 @@ protected void compactIfNecessary(BaseHoodieWriteClient
writeClient, String inst
// Trigger compaction with suffixes based on the same instant time. This
ensures that any future
// delta commits synced over will not have an instant time lesser than the
last completed instant on the
// metadata table.
- final String compactionInstantTime = latestDeltaCommitTimeInMetadataTable
+ METADATA_COMPACTION_TIME_SUFFIX;
+ if (latestDeltaCommitTimeInMetadataTable.length() >
MILLIS_INSTANT_TIMESTAMP_FORMAT_LENGTH) {
+
checkState(latestDeltaCommitTimeInMetadataTable.endsWith(METADATA_TABLE_INIT_TIME_SUFFIX),
Review Comment:
Will this affect compaction of existing metadata partition? If so, we may
need to recreate the table in upgrade step. Let's make sure adding a new suffix
is backwards compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
