alexeykudinkin commented on code in PR #6815:
URL: https://github.com/apache/hudi/pull/6815#discussion_r1085666940
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/HoodieFlinkTable.java:
##########
@@ -53,6 +53,27 @@ protected HoodieFlinkTable(HoodieWriteConfig config,
HoodieEngineContext context
super(config, context, metaClient);
}
+ @Override
Review Comment:
This just been moved; no changes (there were other changes, but these were
reverted back)
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/HoodieSparkTable.java:
##########
@@ -121,4 +107,41 @@ public Runnable getPreExecuteRunnable() {
final TaskContext taskContext = TaskContext.get();
return () -> TaskContext$.MODULE$.setTaskContext(taskContext);
}
+
+ @Override
+ public void close() {
+ try {
+ metadataBroadcast.getValue().close();
+ metadataBroadcast.destroy();
+ } catch (Exception e) {
+ throw new HoodieException(e);
+ }
+ }
+
+ public static <T> HoodieSparkTable<T> create(HoodieWriteConfig config,
HoodieEngineContext context) {
Review Comment:
These ones were moved as is
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/HoodieJavaTable.java:
##########
@@ -37,10 +37,16 @@
public abstract class HoodieJavaTable<T>
extends HoodieTable<T, List<HoodieRecord<T>>, List<HoodieKey>,
List<WriteStatus>> {
+
protected HoodieJavaTable(HoodieWriteConfig config, HoodieEngineContext
context, HoodieTableMetaClient metaClient) {
super(config, context, metaClient);
}
+ @Override
+ protected HoodieIndex getIndex(HoodieWriteConfig config, HoodieEngineContext
context) {
Review Comment:
No changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
