garyli1019 commented on pull request #1602: URL: https://github.com/apache/incubator-hudi/pull/1602#issuecomment-630364085
Hi @nsivabalan > If we could log bytesOccupied by actual records separately and then bytes including bloom separately, it might solve the issue and it would be simpler isn't? Yes, at this point we don't log `bytesOccupied` anywhere. As Vinoth mentioned, we can build a separate statistical table in the long term. Or we can add another column to store this. In HoodieMergeHandle, the `fileSizeInBytes` was calculated by getting the file size directly, so we don't know how many bytes are from the bloom filter. https://github.com/apache/incubator-hudi/blob/master/hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java#L284 If you are looking for how the bloom filter was calculated: https://github.com/apache/incubator-hudi/blob/fa36082554373dd4dce3e3d3159ab87300a4601d/hudi-client/src/main/java/org/apache/hudi/io/storage/HoodieStorageWriterFactory.java#L57 https://github.com/apache/incubator-hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/bloom/BloomFilterFactory.java#L36 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
