alexeykudinkin commented on code in PR #7461:
URL: https://github.com/apache/hudi/pull/7461#discussion_r1085790661
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/HoodieMergeHelper.java:
##########
@@ -123,8 +123,12 @@ public void runMerge(HoodieTable<?, ?, ?, ?> table,
Configuration bootstrapFileConfig = new
Configuration(table.getHadoopConf());
bootstrapFileReader =
HoodieFileReaderFactory.getReaderFactory(recordType).getFileReader(bootstrapFileConfig,
bootstrapFilePath);
- recordIterator = new MergingIterator(baseFileRecordIterator,
bootstrapFileReader.getRecordIterator(),
- (left, right) -> left.joinWith(right,
mergeHandle.getWriterSchemaWithMetaFields()));
+
+ recordIterator = new MergingIterator<>(
+ baseFileRecordIterator,
+ bootstrapFileReader.getRecordIterator(),
+ (left, right) ->
+ left.joinWith(right,
mergeHandle.getWriterSchemaWithMetaFields()));
Review Comment:
There was an actual change here (we're passing the schema), but this change
is reverted now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
