alexeykudinkin commented on code in PR #7744:
URL: https://github.com/apache/hudi/pull/7744#discussion_r1085908275
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadata.java:
##########
@@ -138,12 +138,15 @@ static HoodieBackedTableMetadata
createHoodieBackedTableMetadata(HoodieEngineCon
FileStatus[] getAllFilesInPartition(Path partitionPath) throws IOException;
/**
- * Fetch list of all partitions path that whose relative partition paths
match the given prefixes
+ * Fetch list of all partitions path that whose relative partition paths is
under the
Review Comment:
nit: `Fetch list of all partitions paths that are the sub-directories of the
list of provided (relative) paths`
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -150,9 +152,11 @@ protected Option<HoodieRecord<HoodieMetadataPayload>>
getRecordByKey(String key,
}
@Override
- public List<String> getPartitionPathsWithPrefixes(List<String> prefixes)
throws IOException {
+ public List<String> getPartitionPathsInDirs(List<String> relativePaths)
throws IOException {
return getAllPartitionPaths().stream()
- .filter(p -> prefixes.stream().anyMatch(p::startsWith))
+ .filter(p -> relativePaths.stream().anyMatch(relativePath ->
+ StringUtils.isNullOrEmpty(relativePath)
Review Comment:
Let's leave a TODO to kill this branch (no need to tackle it in this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
