xushiyan commented on code in PR #7723:
URL: https://github.com/apache/hudi/pull/7723#discussion_r1087464631
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeleteHelper.java:
##########
@@ -50,6 +50,7 @@
BaseDeleteHelper<EmptyHoodieRecordPayload,
List<HoodieRecord<EmptyHoodieRecordPayload>>, List<HoodieKey>,
List<WriteStatus>, R> {
private FlinkDeleteHelper() {
+ super(ignored -> -1);
Review Comment:
wouldn't this affect flink users who do not set delete parallelism? as
`deduceShuffleParallelism()` not used here but default value changed from 200
-> 0
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/commit/JavaDeleteHelper.java:
##########
@@ -47,6 +47,7 @@
BaseDeleteHelper<EmptyHoodieRecordPayload,
List<HoodieRecord<EmptyHoodieRecordPayload>>, List<HoodieKey>,
List<WriteStatus>, R> {
private JavaDeleteHelper() {
+ super(ignored -> -1);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
