alexeykudinkin commented on code in PR #7476:
URL: https://github.com/apache/hudi/pull/7476#discussion_r1089552156
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/execution/TestDisruptorExecutionInSpark.java:
##########
@@ -93,11 +91,11 @@ public Integer finish() {
return count;
}
};
- DisruptorExecutor<HoodieRecord, Tuple2<HoodieRecord,
Option<IndexedRecord>>, Integer> exec = null;
+ DisruptorExecutor<HoodieRecord, HoodieRecord, Integer> exec = null;
try {
- exec = new
DisruptorExecutor(hoodieWriteConfig.getDisruptorWriteBufferSize(),
hoodieRecords.iterator(), consumer,
- getCloningTransformer(HoodieTestDataGenerator.AVRO_SCHEMA),
Option.of(WaitStrategyFactory.DEFAULT_STRATEGY), getPreExecuteRunnable());
+ exec = new
DisruptorExecutor<>(writeConfig.getWriteExecutorDisruptorWriteBufferSize(),
hoodieRecords.iterator(), consumer,
+ Function.identity(), WaitStrategyFactory.DEFAULT_STRATEGY,
getPreExecuteRunnable());
Review Comment:
There's no reason to over-complicate this test -- it's goal is to test the
Executor not how it's being used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
